Multitap (PCSX2)

[KrossX]

Fixed! Now it's a pretty grey thing.



It was due to a PDA (PocketStation) command, that I didn't even know it existed cuz I didn't want to emulate one. Worse, it didn't matter the returned data but the "plugged" state. So if that commands happens, and the device is "plugged" then hey! Gotta be a Pocketstation.

Grrr....

Anyhow, now there's the dialog work and stuff... and it would be done. Nice that you can copy the saves to the PS2 card, like a backup.

#EDIT: Not bad, not bad.

[refraction]

excellent work so far mate! Very very impressed!

[KrossX]

Done!
Build + source/patch attached on 1st post.

I think that's it, there are files with the new sio stuff and patch for the memcard dialog stuff.

[avih]

Done!
Build + source/patch attached on 1st post.

I think that's it, there are files with the new sio stuff and patch for the memcard dialog stuff.

Very nice

Re this:

Code:

+        case McdColS_Type:            return prefix + ( !it.IsPresent ? L"" : ( it.Type? _("PSX") : _("PS2")) );

and

+uint FileMemoryCard::GetType( uint slot )

etc. : use enum or IsPsx

Care to make Type an enum? or at least change its name to IsPsx (both the property and all the functions) if it's a bool anyway and means exactly that (if you don't expect more types anytime soon)?

Cool patch, thanks

[KrossX]

Done! Went the bool route, and also some minor change to the PS2/PSX sio_memcard part.
Build + source/patch attached on 1st post as usual.

For future reference:
nocash - psx memcard file system
Ross Ridge - ps2 memcard file system

For the idea of making a quicky check instead of a memcard CRC. /* Auto eject feature */

[avih]

Done! Went the bool route, and also some minor change to the PS2/PSX sio_memcard part.
Build + source/patch attached on 1st post as usual.
...

Cool
Want me to commit this code to the repository?

[refraction]

Cool
Want me to commit this code to the repository?

yes please ;p

[avih]

yes please ;p

KrossX, OK, I applied the patch, it compiles and appears to be working (at least the MCD config panel, didn't test multitap or PSX cards).

Could you please write a commit message of what this patch does/fix?

Once I have this, I'll commit it. Thanks again

[KrossX]

Roger that. Let's see...

* Added support for raw PSX memory cards (mcd/mcr)
* Fixes issues with pads on port2 (eg, Fixes Issue 1326)
* Fixes multitap (eg, TimeSplitters)

That's it, a small list of low priority things.

Optional
* Fixes high framerate problems by increasing CPU usage.

[avih]

r5622

Thanks