Login

**ssakash** · 05-30-2015, 01:54 PM

(05-30-2015, 01:50 PM)refraction Wrote: Yeah gsdx has 2 configuration windows, that is the old one. Think there might already be a thread on bug reports?

why wasn't the old one deprecated yet ? Tongue2

I guess I found the cause of this bug, I'll try looking into it. could you link the bug report ? that would help, I can't find it yet.

***refraction*** · 05-30-2015, 05:03 PM

I can't no Tongue

**ssakash** · (This post was last modified: 05-31-2015, 04:18 PM by ssakash.)

cool, I fixed the issue. now PCSX2 wouldn't use that outdated GUI. download the following plugin and place it in the plugins folder and the issue won't happen anymore, I will make a PR for this in a short while.

daman6009.home.comcast.net/GSdx32-SSE2.7z

Thanks to Daman for compiling the commit and hosting it on his own site. Smile

PR link: https://github.com/PCSX2/pcsx2/pull/567

***refraction*** · 05-31-2015, 04:35 PM

as this now has a PR, on ssakash's request, moving to the bugs forum

**ssakash** · (This post was last modified: 05-31-2015, 04:55 PM by ssakash.)

Thanks refraction, I'll move this to the pushed bug reports. since, an Issue also has been made based on this on Github.

Thank you for your report.
This bug report has now been marked as Pushed and has been posted as an issue in our Github repository HERE

Issue link: https://github.com/PCSX2/pcsx2/issues/566

This thread will now be moved in the Pushed bug reports subforum.

Ge-Force · (This post was last modified: 05-31-2015, 05:07 PM by Ge-Force.)

I feel the change in the PR isn't the correct way to solve this bug. IIRC GSDX can also be used with PSX emulators? will this fix cause issues with them?

After having a quick poke around the code, The constructor for GSSettingsDlg is called using s_isgsopen2, which is only set to true when PS2EsetEmuVersion is called from PCSX2 (specifically, here https://github.com/PCSX2/pcsx2/blob/98d2...r.cpp#L868 ). Why this doesn't happen during the First time config, I don't know.

**ssakash** · (This post was last modified: 05-31-2015, 06:11 PM by ssakash.)

(05-31-2015, 05:07 PM)Ge-Force Wrote: I feel the change in the PR isn't the correct way to solve this bug. IIRC GSDX can also be used with PSX emulators? will this fix cause issues with them?

I don't think it will cause any conflicts on the PSX emulation side, It uses the IDD_GPUCONFIG for the plugin settings format, It has nothing to do with the IDD_CONFIG2.

Quote:After having a quick poke around the code, The constructor for GSSettingsDlg is called using s_isgsopen2, which is only set to true when PS2EsetEmuVersion is called from PCSX2 (specifically, here https://github.com/PCSX2/pcsx2/blob/98d2...r.cpp#L868 ). Why this doesn't happen during the First time config, I don't know.

The changes I done revolve around Isopen2. It just replaces the instance when the IDD_CONFIG is used with IDD_CONFIG2 (current one). this was the only instance where the old format is kept used so evidently the changes should have been for the First time config. the s_isgsopen2 is defaulted to false and is only true during the instance you had mentioned, I have no idea why it is so.

**rama** · 05-31-2015, 07:02 PM

Honestly, I've already forgotten what (if anything) required the original GSOpen to still be around.

***refraction*** · 05-31-2015, 08:52 PM

Same, there "was" a reason at one point, but now its just an incomprehensible mess.

**gregory** · 06-01-2015, 01:20 PM

gs open 1 is used when you replay gs dump (and potentially PS1 emulator)

Login
Username:
Password:	Lost Password?
	Remember me