EE slider

[billyash]

i saw some changes GUI that sskash does. he good at gui. while ee overclock and underclock can be change from pcsx2_vm.ini that already done by rama. my sugestion. why don't we make  slider on ee overclock and underclock ?  i think sskash can do that. it is just my sugestion.  thank you  

[ssakash]

Not really, Overclocking EE was never enabled through the pcsx2_vm.ini.

take a look at the code,

Code:

if (EmuConfig.Speedhacks.EECycleRate > 2 && EmuConfig.Speedhacks.EECycleRate < 100) {
        scalarLow *= EmuConfig.Speedhacks.EECycleRate;
        scalarMid *= EmuConfig.Speedhacks.EECycleRate;
        scalarHigh *= EmuConfig.Speedhacks.EECycleRate;
        }

where it only accepts value between 3-99 and pumps up the scalar values even higher depending on the value. so overclocking was never done before

overclocking is fairly simple though. just reduce the scalar values even further to make sure that the scale of cycles per instructions are even higher (or) something. not sure though, Ref didn't give me much idea

I could implement overclocking on the GUI but there are some reasons on why I wouldn't do so,

1/ Blyss already did this and didn't PR it for some reasons, If I did this now it would be like stealing other person's valuable work which would be disturbing me.

2/ see reason #1

That's all

[billyash]

is it mean, it will never be implemented?

[Nobbs66]

It was never PR'd because Avih was supposed to be working on a better way to implement it. The current system won't allow for a predictable overclock on the EE.

[ssakash]

is it mean,  it will never be implemented?

not really, I mean I'll wait for Blyss to PR it (it was his idea). don't really know why he didn't PR yet though
If he doesn't want to do it for some reasons, maybe I'll consider it.

It was never PR'd because Avih was supposed to be working on a better way to implement it. The current system won't allow for a predictable overclock on the EE.

better way ? what would that be ?

[Nobbs66]

It's in this issue
https://github.com/PCSX2/pcsx2/issues/153

[willkuer]

Timing seems to be fixed in an arbitrary way.

They first want to fix timing to an accurate way before they want to play with clocks.
There is somewhere an open github issue showing some part of the discussion.


Edit:

-.-''
You are too fast.

[ssakash]

bumped up the issue a bit , maybe I'll get a response

[billyash]

It's in this issue
https://github.com/PCSX2/pcsx2/issues/153

i think slider in real clock ( Mhz) is good idea. instead of  EE cyclerate :

[avih]

i think slider in real clock ( Mhz) is good idea. instead of  EE cyclerate :

If it was as simple as that then it wouldn't be under the tab speed _hacks_. The whole point is that setting the speed correctly depends on much deeper PCSX2 working,(super non trivial and impossible with the current PCSX2 design), and therefore the approach which the slider affects is a big hack. It sort of works, and that's why it's there.

My request was to add whatever new hack values he wants, but keep the existing hacks intact - both in slider value and in their effect (the configuration values they induce), e.g. by adding new slider values to the left, and IIRC the original patch did neither of those.