GSdx

[messiahgov]

Thanks for your answer, so I can probably mark off the hotkeys question. =) I think "PgUp" still just de-/activates the build-in FXAA.
I'm not sure that I will recognize the difference. It seems that the PCSX2 log doesn't show any info about a loaded *.fx or anything. Would be nice to see any "loaded shader.fx" line.

I read some more forum posts and it might be, that the built-in FXAA and "GSdx.fx" can run together, but it's advised to just deactivate FXAA from PCSX2 and activate the one that comes with "GSdx.fx". Even if both seem to be from Asmodean.

So now I only need to find out, if a "shader.fx" (@ root next to "pcsx2.exe") replaces the "GSdx.fx" ("shaders" folder) or how it exactly works. Which one gets loaded, maybe just both? The Wiki says, that only the "GSdx.fx" (+ ini) needs to be in the "shaders" folder, any other has to be at PCSX2's root. But there's only one check box to "Enable FX Shader". The last PCSX2 version I had, there wasn't any "GSdx.fx", just different "shader.fx" files, each need to be placed in PCSX2's root to use (with "Enable FX Shader")

[messiahgov]

Okay, so after some testing, it seems that the new GSdx plugin doesn't recognize any "shader.fx" file anywhere, equal if it's next to "pcsx2.exe" or inside the "shaders" folder. Only a "GSdx.fx" named shader file inside the "shaders" folder gets loaded.

[tsunami2311]

Could swore people where saying round sprite was fixing menus in FFX to a point? https://github.com/PCSX2/pcsx2/issues/500 according to that state 2 should do something but for me it does nothing

Above link list the hack as "UserHacks_round_sprite_offset="

in gsdx.ini its listed as "UserHacks_round_sprite="

now setting it with in the ui for any state does nothing, but if I manual edit the ini say "UserHacks_round_sprite_offset=2" It in deed helps the FFX menus some.

I am thinking typo? cause "UserHacks_round_sprite=" does nothing and the ini should be saying "UserHacks_round_sprite_offset="

Witch looking at the git info it show the hack as "UserHacks_round_sprite="

OR maybe i doing something wrong and i need sleep but for me "UserHacks_round_sprite=" in the gsdx ini does nothing and i had to manual change it to "UserHacks_round_sprite_offset=" to effect changes which mean the UI control for round sprite currently broke?

[karasuhebi]

Yeah tsunami2311, that sounds like a typo. ssakash, what did you do? XD

It seems that the PCSX2 log doesn't show any info about a loaded *.fx or anything. Would be nice to see any "loaded shader.fx" line.

Try turning on more sources in the log window.

[Blyss Sarania]

Yeah, apparently on line 604 and 667 of GSSettingsDialog.cpp ssakash called it "Userhacks_round_sprite" which is then what gets transferred over to the ini. It needs to be "Userhacks_round_sprite_offset"

If I wasn't about to go to bed I'd fix it. Oh well, if it's not done by tomorrow I will.

[Blyss Sarania]

Also, the description text is a bit hard to understand:

"Fixes lines in sprites of games like Ar tonelico when upscaling.\n\n"

"carries total of three states, Unchecked (off), Squared check box (on for all sprites) checked box (on for flat sprites)";

"Flat Sprites"? A sprite is by definition 2D... so IDK what you are trying to say there.

Also call it a "shaded check box" not a squared one.

And it needs more game examples because it has a much wider scope than the old one which he made for Ar tonelico.

"Carries" should be capitalized as well, although I would just say "Has three states"

[gregory]

"Flat Sprites"? A sprite is by definition 2D... so IDK what you are trying to say there.

I think it comes from my commit. Well, all primitives are 2D anyway It must be read as nearest filtered sprite (vs bilinear filtered sprite) but I found flat nicer (even if it is a very bad word)

[Ryudo]

Also, the description text is a bit hard to understand:


"Flat Sprites"? A sprite is by definition 2D... so IDK what you are trying to say there.

Also call it a "shaded check box" not a squared one.

And it needs more game examples because it has a much wider scope than the old one which he made for Ar tonelico.

"Carries" should be capitalized as well, although I would just say "Has three states"

Shouldn't shaded (squared, whichever) be 'partially' applied basically only and the full checked box apply it to all sprites? That's how it is for Texture Filtering too.

[ssakash]

OR maybe i doing something wrong and i need sleep but for me "UserHacks_round_sprite=" in the gsdx ini does nothing and i had to manual change it to "UserHacks_round_sprite_offset=" to effect changes which mean the UI control for round sprite currently broke?

just made a PR to fix the typo. unfortuantely, somehow I added a extra unrelated commit to the PR. so, I decided to rebase and F-push it to delete the unrelated commit but, now Github gives the following error while trying to access.



From the looks of it, I think it would take a little more time to get the PR rebased and get it ready to be merged because of this server problem.

[Edit]

The server is back on and the PR has been successfully rebased and sent. The sync between the ini file and the UI is corrected.

[ssakash]

Shouldn't shaded (squared, whichever) be 'partially' applied basically only and the full checked box apply it to all sprites? That's how it is for Texture Filtering too.

changing the variables for the states require changing the native function for the BS_AUTO3STATE and it would influence all the other hacks which use the three state check box and it would get messy.

I tried using parameters for the function call for the initialization of the value for the variable and somehow it still uses the native one and the change is not getting done right. so, I decided it would be better to just notify about the hack in the description and leave it at the default way.

Though, there is still a clean alternative for making it the right way. that would require gregory to swap the value for the Hw hack and it would be sorted out the right way. but still, gregory feels that it would be better to have the values at the current way for future access.

Also call it a "shaded check box" not a squared one.

done.

"Carries" should be capitalized as well, although I would just say "Has three states"

done.

And it needs more game examples because it has a much wider scope than the old one which he made for Ar tonelico.

Yes, that could be added. highlighting the popular games which benefit from the hack would be good for the description, It would be nice if anyone could put up a list of games which are benefited from the hack.