Posts: 6.069
Threads: 68
Joined: May 2010
Reputation:
167
Location: Grenoble, France
07-20-2014, 03:43 PM
(This post was last modified: 07-20-2014, 04:04 PM by gregory.)
Personally no opinion but it could reduce a bit PCSX2 complexity.
Pros:
* remove 12K line of code (of non portable i386 arch)
* reduce testing/configuration
Cons:
* a couple of games (maybe 1 actually?) don't work with micro VU
* urban legend say svu is faster but MTVU is much faster anyway
Posts: 21.718
Threads: 401
Joined: Sep 2013
Reputation:
476
Location: 私の夢の中
07-20-2014, 03:46 PM
(This post was last modified: 07-20-2014, 03:47 PM by Blyss Sarania.)
You guys were speaking of this in IRC the other day.
I vote remove. I think there are like 2-3 games that are faster with it, but removing 12k lines of complexity from the code far outweighs that IMO.
If you remove it, don't forget to remove the manual gamefixes that only apply for SVU(of which there is at least 1 that I know of!)
Gaming Rig: Intel i7 6700k @ 4.8Ghz | GTX 1070 TI | 32GB RAM | 960GB(480GB+480GB RAID0) SSD | 2x 1TB HDD
Posts: 3.526
Threads: 6
Joined: Dec 2013
the con is only that 1(?) game that relies on it. leave the code files in but excude it from building. i'm sure there's a way save patching macroing define it out to be still able to include for custom builds for people that want it. fair balance between your maintenance and user preference. imho
Posts: 6.069
Threads: 68
Joined: May 2010
Reputation:
167
Location: Grenoble, France
Honestly I don't know which games that rely on superVU. Dunno if there is a list somewhere.
Posts: 216
Threads: 7
Joined: Feb 2009
Reputation:
3
I say remove all of it. Compatibility with one game isn't worth it to keep it in. If someone cares enough then they can track down the bug with older builds that do include sVU.
Main Rig: i5 4670k, 16GB RAM, Nvidia 770 GTX, Windows 8.1/Arch
Main Laptop: Toshiba Kirabook. i5 4200U, 8 GB RAM, windows 8.1/Arch
Posts: 20.326
Threads: 405
Joined: Aug 2005
Reputation:
554
Location: England
07-20-2014, 06:44 PM
(This post was last modified: 07-20-2014, 07:00 PM by refraction.)
It's much more than 1 game. Search the contents of the public compatibility list (with the old method, not google) for the term "SuperVU" in the entire post, there's about 20 games which don't run right (or at all) with MicroVU and work much better on SuperVU.
I'd say keep it for now, until the problems are solved on microvu.
Posts: 6.069
Threads: 68
Joined: May 2010
Reputation:
167
Location: Grenoble, France
Ah handy. Interesting figure. We should really put this list on some Wiki. So yes it seems to soon to drop superVU.