Posts: 1.909
Threads: 28
Joined: Jun 2010
Reputation:
75
Hmm.. oh... sio.h/cpp and sio_internal.h are not part of the patch. So I didn't include them. It seems a complete rewrite of some files...
Ref, did you go over those files? wanna commit them?
Posts: 923
Threads: 7
Joined: Jan 2012
Reputation:
47
Location: Argentina
The patch was only the memcard dialog and type check.
I worked on the rewrite on different files for quick switch between the old method. So I just copied them instead of replacing the originals for a patch file. Sorry.
Posts: 1.909
Threads: 28
Joined: Jun 2010
Reputation:
75
Hmm.. I think I'll commit it anyway (v6), to gather some feedback from users, mostly to see if stuff got broken as a result. And if it gets reviewed and changes are required, we'll fix it later, or at the worst case, revert the patch.
I'll do that tomorrow.
Posts: 923
Threads: 7
Joined: Jan 2012
Reputation:
47
Location: Argentina
It can wait though, as I still wanna make the quicky check for memcards (auto-eject feature).
Posts: 20.318
Threads: 405
Joined: Aug 2005
Reputation:
551
Location: England
That would be nice, it's quite imperative that cards can eject and reload when a savestate is used.
Posts: 1.909
Threads: 28
Joined: Jun 2010
Reputation:
75
04-29-2013, 12:01 AM
(This post was last modified: 04-29-2013, 12:04 AM by avih.)
Oh, on that case, post here when you want to commit it?
Also, how would PCSX2 behave with only the memcards patches applied (as it is now)? Should I revert it until the full patch? or is it mostly harmless? (seems mostly harmless to me)