Not so much a bug, but a feature that was removed.
#1
In previous versions (the last version I used was 1.3.0-734), when you were in the console log, after you changed/added/disabled cheats, whichever. You could drag the scrollbar down, and it would automatically update whatever cheats were active or changed, and also state again how many cheats were loaded (this is due to the update that it did). This is no longer possible apparently in 1.3.1. Is there any way of returning this feature? It was handy to quickly enable or disable codes this way. And now I have to restart the entire game every time to make one minor change to a code.

[Edit]
Nevermind, it seems the cheats are being updated still, it's just not showing in the console anymore? I still think this particular part should be returned. I understand the whole 'console cleanup' thing was implemented to make it look cleaner, but the cheats that were loaded etc, is still an important part of being shown imo.
AMD Ryzen 5 3600 @ 3.60~4.20 GHz | Corsair Vengeance LPX 32 GB (2x16GB) DDR4-3200
MSI GeForce GTX 1660 Super @ 6 GB | Samsung 980 1TB | Windows 10 Pro x64 (22H2)

Sponsored links

#2
The issue was that it would display all the cheats every time you change aspect ratio or modify other unrelated config, and it would just spam the console with these patches messages.

So now you only see a summary of the patches at the console and only once when the game boots - unless you enable at the console sources: Dev/Verbose, at which case you should see all the patches messages again.

Updating the cheats shouldn't have changed, but let me know if it you think did change.
#3
You do not have to restart the entire game to enable a cheat.

You just enable the cheat in the pnach file while the game is running and then just fast-forward a few seconds and the cheat will be enabled.
#4
Actually going to kick this topic back up.

It doesn't say whether cheats are enabled in both the console window, AND the emulog now.
This is problematic if we want to help users identify bugs, because now we have to ask every time if they're running any cheats, and in the past it would show up in the emulog, saving a bit of time on this part.

Can you at least make it so that it shows up in the emulog.txt file whether cheats were enabled or not?
AMD Ryzen 5 3600 @ 3.60~4.20 GHz | Corsair Vengeance LPX 32 GB (2x16GB) DDR4-3200
MSI GeForce GTX 1660 Super @ 6 GB | Samsung 980 1TB | Windows 10 Pro x64 (22H2)
#5
What exactly was it showing before that it doesn't show now?
#6
Ok.. example:

PCSX2 1.3.0-639
Code:
Loading language translation databases for 'Dutch' [nl_NL]
    pcsx2_Main not found -- translation dictionary may be incomplete.
    pcsx2_Iconized not found -- translation dictionary may be incomplete.
SetLanguage: Requested translation is not implemented yet.
PCSX2 1.3.0-20141004113334 - compiled on Oct  4 2014
Savestate version: 0x9a0a0000

Host Machine Init:
    Operating System =  Microsoft Windows 7 Ultimate Edition Service Pack 1 (build 7601), 64-bit
    Physical RAM     =  6081 MB
    CPU name         =  Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz
    Vendor/Model     =  GenuineIntel (stepping 03)
    CPU speed        =  3.398 ghz (4 logical threads)
    x86PType         =  Standard OEM
    x86Flags         =  bfebfbff 7fdafbbf
    x86EFlags        =  2c100000

x86 Features Detected:
    SSE2.. SSE3.. SSSE3.. SSE4.1.. SSE4.2.. AVX.. FMA

Loading language translation databases for 'Dutch' [nl_NL]
    pcsx2_Main not found -- translation dictionary may be incomplete.
    pcsx2_Iconized not found -- translation dictionary may be incomplete.
SetLanguage: Requested translation is not implemented yet.
Reserving memory for recompilers...

Loading plugins...
    Binding   GS: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\GSdx32-SSE4.dll
Windows 6.1.7601 (Service Pack 1 1.0)
    Binding  PAD: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\LilyPad.dll
    Binding SPU2: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\SPU2-X.dll
    Binding CDVD: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\cdvdGigaherz.dll
    Binding  USB: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\USBnull.dll
    Binding   FW: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\FWnull.dll
    Binding DEV9: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\DEV9null.dll
Plugins loaded successfully.

(GameDB) 9653 games on record (loaded in 165ms)
HLE Notice: ELF does not have a path.


Initializing plugins...
    Init GS
Windows 6.1.7601 (Service Pack 1 1.0)
    Init PAD
    Init SPU2
    Init CDVD
    Init USB
    Init FW
    Init DEV9
Plugins initialized successfully.

Opening plugins...
    Opening GS
    Opening PAD
    Opening SPU2
    Opening CDVD
isoFile open ok: E:\PS2 ISOs\Dawn of Mana (NTSC).iso
    Image type  = DVD
* CDVD Disk Open: DVD, Single layer or unknown:
* * Track 1: Data (Mode 1) (1717536 sectors)
    Opening USB
    Opening FW
    Opening DEV9
McdSlot 0: F:\Users\Ryudo\Documents\PCSX2\memcards\Mcd001.ps2
McdSlot 1: F:\Users\Ryudo\Documents\PCSX2\memcards\Mcd002.ps2
Plugins opened successfully.
EE/iR5900-32 Recompiler Reset
    Bios Found: USA     v02.30(20/02/2008)  Console
    BIOS rom2 module not found, skipping...
    BIOS erom module not found, skipping...
(UpdateVSyncRate) Mode Changed to NTSC.
(UpdateVSyncRate) FPS Limit Changed : 59,94 fps
(SYSTEM.CNF) Detected PS2 Disc = cdrom0:\SLUS_215.74;1
(SYSTEM.CNF) Software version = 1.00
(SYSTEM.CNF) Disc region type = NTSC
ELF (cdrom0:\SLUS_215.74;1) Game CRC = 0x9DC6EE5A, EntryPoint = 0x00100008
(SYSTEM.CNF) Detected PS2 Disc = cdrom0:\SLUS_215.74;1
(SYSTEM.CNF) Software version = 1.00
(SYSTEM.CNF) Disc region type = NTSC
Found Cheats file: '9DC6EE5A.pnach'
comment: Patch by Ryudo
Loaded 16 Cheats from '9DC6EE5A.pnach'
Overall 16 Cheats loaded
Overall 0 Widescreen hacks loaded
Loading patch '9DC6EE5A.pnach' from archive 'C:\pcsx2\PCSX2 GIT 1.3.0-639\cheats_ws.zip'
comment: Widescreen hack
(Wide Screen Cheats DB) Patches Loaded: 1
Closing plugins...
    Closing DEV9
    Closing FW
    Closing USB
    Closing CDVD
    Closing SPU2
    Closing PAD
    Closing GS
Plugins closed successfully.
Decommitting host memory for virtual systems...
EE/iR5900-32 Recompiler Reset
Shutting down plugins...
Plugins shutdown successfully.
(GameDB) Unloading...

In particular:

Code:
(SYSTEM.CNF) Detected PS2 Disc = cdrom0:\SLUS_215.74;1
(SYSTEM.CNF) Software version = 1.00
(SYSTEM.CNF) Disc region type = NTSC
Found Cheats file: '9DC6EE5A.pnach'
comment: Patch by Ryudo
Loaded 16 Cheats from '9DC6EE5A.pnach'
Overall 16 Cheats loaded



Now in PCSX2 1.3.1-10:

Code:
Loading language translation databases for 'Dutch' [nl_NL]
    pcsx2_Main not found -- translation dictionary may be incomplete.
    pcsx2_Iconized not found -- translation dictionary may be incomplete.
SetLanguage: Requested translation is not implemented yet.
PCSX2 1.3.1-20150210224929 - compiled on Feb 10 2015
Savestate version: 0x9a0a0000

Host Machine Init:
    Operating System =  Microsoft Windows 7 Ultimate Edition Service Pack 1 (build 7601), 64-bit
    Physical RAM     =  6081 MB
    CPU name         =  Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz
    Vendor/Model     =  GenuineIntel (stepping 03)
    CPU speed        =  3.398 ghz (4 logical threads)
    x86PType         =  Standard OEM
    x86Flags         =  bfebfbff 7fdafbbf
    x86EFlags        =  2c100000

x86 Features Detected:
    SSE2.. SSE3.. SSSE3.. SSE4.1.. SSE4.2.. AVX.. FMA

Loading language translation databases for 'Dutch' [nl_NL]
    pcsx2_Main not found -- translation dictionary may be incomplete.
    pcsx2_Iconized not found -- translation dictionary may be incomplete.
SetLanguage: Requested translation is not implemented yet.
Reserving memory for recompilers...

Loading plugins...
    Binding   GS: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\GSdx32-SSE4.dll
Windows 6.1.7601 (Service Pack 1 1.0)
    Binding  PAD: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\LilyPad.dll
    Binding SPU2: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\SPU2-X.dll
    Binding CDVD: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\cdvdGigaherz.dll
    Binding  USB: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\USBnull.dll
    Binding   FW: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\FWnull.dll
    Binding DEV9: C:\pcsx2\PCSX2 GIT 1.3.1-10\plugins\DEV9null.dll
Plugins loaded successfully.

(GameDB) 9677 games on record (loaded in 162ms)
HLE Notice: ELF does not have a path.


Initializing plugins...
    Init GS
Windows 6.1.7601 (Service Pack 1 1.0)
    Init PAD
    Init SPU2
    Init CDVD
    Init USB
    Init FW
    Init DEV9
Plugins initialized successfully.

Opening plugins...
    Opening GS
    Opening PAD
    Opening SPU2
    Opening CDVD
isoFile open ok: E:\PS2 ISOs\Dawn of Mana (NTSC).iso
    Image type  = DVD
* CDVD Disk Open: DVD, Single layer or unknown:
* * Track 1: Data (Mode 1) (1717536 sectors)
    Opening USB
    Opening FW
    Opening DEV9
McdSlot 0: F:\Users\Ryudo\Documents\PCSX2\memcards\Mcd001.ps2
McdSlot 1: F:\Users\Ryudo\Documents\PCSX2\memcards\Mcd002.ps2
Plugins opened successfully.
EE/iR5900-32 Recompiler Reset
    Bios Found: USA     v02.30(20/02/2008)  Console
    BIOS rom2 module not found, skipping...
    BIOS erom module not found, skipping...
(UpdateVSyncRate) Mode Changed to NTSC.
(UpdateVSyncRate) FPS Limit Changed : 59,94 fps
(SYSTEM.CNF) Detected PS2 Disc = cdrom0:\SLUS_215.74;1
(SYSTEM.CNF) Software version = 1.00
(SYSTEM.CNF) Disc region type = NTSC
ELF (cdrom0:\SLUS_215.74;1) Game CRC = 0x9DC6EE5A, EntryPoint = 0x00100008
(SYSTEM.CNF) Detected PS2 Disc = cdrom0:\SLUS_215.74;1
(SYSTEM.CNF) Software version = 1.00
(SYSTEM.CNF) Disc region type = NTSC
(Wide Screen Cheats DB) Patches Loaded: 1
Closing plugins...
    Closing DEV9
    Closing FW
    Closing USB
    Closing CDVD
    Closing SPU2
    Closing PAD
    Closing GS
Plugins closed successfully.
Shutting down plugins...
Plugins shutdown successfully.
(GameDB) Unloading...

As you can see, the cheats section is gone in emulog.txt

It shows WS patches fine in the logs, but regular cheats no more.
AMD Ryzen 5 3600 @ 3.60~4.20 GHz | Corsair Vengeance LPX 32 GB (2x16GB) DDR4-3200
MSI GeForce GTX 1660 Super @ 6 GB | Samsung 980 1TB | Windows 10 Pro x64 (22H2)
#7
Please provide exact steps to reproduce this, preferably starting with a clean portable instal directory.

e.g.:
- download pcsx2blah-blah.7z and extract it, put the bios files at the bios directory, run pcsx2 and accept the default plugins, cdvd -> choose iso, fast boot.

- result with earlier versions: A, B, C
- result with newer versions: X, Y, Z

Also, you mentioned earlier that something changed at one or more window titles? please put all the issues you find from these two commits in one clear post. Thanks.
#8
Tested on freshly downloaded portable versions from buildbot;

PCSX2 1.3.0-882 - Emulog still shows when cheats are enabled or not.
PCSX2 1.3.0-883 and beyond - Emulog no longer shows whether cheats are enabled or not.

How to reproduce:
Just get an emulog by starting up pcsx2 and run a game with cheats enabled.


Result from PCSX2 1.3.0-882 (Partial emulog, only showing the significant part):
Code:
Found Cheats file: '9DC6EE5A.pnach'
comment: Patch by Ryudo
Loaded 16 Cheats from '9DC6EE5A.pnach' at 'C:\pcsx2\pcsx2-v1.2.1-882-g9495b8e-windows-x86\cheats'
Overall 16 Cheats loaded
Overall 0 Widescreen hacks loaded
Loading patch '9DC6EE5A.pnach' from archive 'C:\pcsx2\pcsx2-v1.2.1-882-g9495b8e-windows-x86\cheats_ws.zip'
comment: Widescreen hack
(Wide Screen Cheats DB) Patches Loaded: 1
Above is what it SHOULD show. And that's correct.


Result from PCSX2 1.3.0-883 (Partial emulog, only showing the significant part):
Code:
(Wide Screen Cheats DB) Patches Loaded: 1

That's all that's being shown now in that particular section. No mention of regular cheats at all.


Quote:v1.3.0-883: patches: reduce console noise for patches/cheats - 1. When changing settings, such as aspect ratio, patches message was spamming the console, now they don't.
v1.3.0-884: patches: move verbose from ELF-log to Dev-verbose - improvements from the previous commit stay (less noisy, better reboot verbose)

As I mentioned in the OP, I understand that you originally implemented this to clean up the console, but having it inside the emulog made it easier to troubleshoot issues with users who were experiencing freezes, etc.
Because we could tell right away from an emulog whether cheats were enabled or not. I don't see any reason to remove this entirely from both the console -and- emulog.txt file.
AMD Ryzen 5 3600 @ 3.60~4.20 GHz | Corsair Vengeance LPX 32 GB (2x16GB) DDR4-3200
MSI GeForce GTX 1660 Super @ 6 GB | Samsung 980 1TB | Windows 10 Pro x64 (22H2)
#9
(02-20-2015, 08:53 PM)Ryudo Wrote: PCSX2 1.3.0-882 - Emulog still shows when cheats are enabled or not.
PCSX2 1.3.0-883 and beyond - Emulog no longer shows whether cheats are enabled or not.

121-884 moved it to the dev/verbose, so please don't test 883.


(02-20-2015, 08:53 PM)Ryudo Wrote: That's all that's being shown now in that particular section. No mention of regular cheats at all.

So the only thing which is missing is mentioning the regular patches?

What about the title of some windows which you mentioned earlier?
#10
Hope this makes everything right: https://github.com/PCSX2/pcsx2/commit/56b2c00

If in devel build mode or if the console devel/verbose source is enabled - all patching info is printed whenever it's applied (typically when any configuration changes) - including patches which were previously only printed on boot - such as games db patches.

Else - it prints all the patch info (including the info which was moved to devel/verbose on 883) only on boot.




Users browsing this thread: 1 Guest(s)