04-26-2014, 09:27 AM
Hum, which things do you want to remove?
PCSX2 Linux Development
|
04-26-2014, 09:27 AM
Hum, which things do you want to remove?
04-26-2014, 01:03 PM
I was thinking about sticking std::thread and std::mutex straight into GSWorker instead of going through IGSThread and IGSLock.
"I know now why you cry... but it is something I can never do."
-Emotion Engine
04-26-2014, 02:44 PM
No don't do that! I really want to keep all thread API (win, pthread and std) for the moment. Std::thread is not supported yet on all platform. It won't kill perf anyway.
04-26-2014, 02:49 PM
OK, understood. You want me to just comment out the pthread stuff then? Or set up a third #ifdef block?
"I know now why you cry... but it is something I can never do."
-Emotion Engine
04-26-2014, 03:34 PM
Add "ENABLE_STD_THREAD" in plugins/GSdx/config.h. Then ifdef the new/old code.
04-26-2014, 10:20 PM
ok, I have written an alternate GSJobQueue. It seems to be working well. I will send a pull request.
"I know now why you cry... but it is something I can never do."
-Emotion Engine
04-26-2014, 11:02 PM
And by "well" I mean it is functional
Whether it is "optimal" is yet to be determined
"I know now why you cry... but it is something I can never do."
-Emotion Engine
04-26-2014, 11:07 PM
(04-23-2014, 08:55 PM)krysto Wrote: Now that PCSX2 is on Github, I'm doing some work on the wiki: Thanks for your work!
I put comment on github. By the way if you have some time to roughly benchmark it, it would be nice
04-27-2014, 04:51 AM
After a brief benchmark unfortunately I have to report that with my new code we are actually at a slight performance loss
Though as discussed on github I will go through and replace all the GS wrappers instead of just the jobqueue. This was mostly just a warm-up exercise to get comfortable working with the GSdx source. However I have been reading on some forums that std::thread is just a wrapper for posix/win thread. If this is true, that would be a real shame, as pthread is already as close to the metal as we can get.
"I know now why you cry... but it is something I can never do."
-Emotion Engine |
« Next Oldest | Next Newest »
|