Resolved: [Bug Report] ICO [NTSC-J]

[Parotaku]

# PCSX2 version: PCSX2 1.5.0-dev-1284 (2016-09-17)
# CPU options: Default settings, except VU0/VU1 Clamping at Extra+preserve sign
# Plugins used: GSdx 20160917 openGL & DX11 - Half pixel offset GS hack

# Description: Good work on fixing ICO's blur with proper custom resolution scaling, looks so much clearer now!
Just a (minor) bug I noted while testing is that hardware mode is missing the 'godrays' effet around some windows...
Not easy to spot on screenshots but you can see it more easily when switching from hardward to software rendering...
I attached a GSdump if someone wants to have a look...

[FlatOut]

I can see the issue in your screenshots and dump, but it's not very clear. I played the game a little and found a great location to see the issue. Here's another dump:

[attachment=60994]

HW:


SW:

[gregory]

CR ? Or standard upscaling

[FlatOut]

The issue is not related to scaling. It's missing on native in HW.

[gregory]

Ok. I'm asking because CR doesn't handle well depth stuff. Hum, could you test SW without mipmapping ?

[Parotaku]

Thanks FlatOut, I forgot I could move the camera up from below... the bug is much more clear on your screenshots...

>gregory
Just tested SW without mipmapping --> godrays are missing too

[Parotaku]

Might be related:
fog effect is missing too around the castle in harware mode...

EDIT: fog still present in SW without mipmapping so that must come from something else...

[FlatOut]

I'm pretty sure I've seen the fog in HW. Might be fixable with a setting or it's a regression. I'll look into it.


EDIT: I didn't get to the tower, but went to a few outside locations and the fog was there. Can't really tell if the fog is missing in HW in the dump.

[Parotaku]

I don't know if it's a regression either but the place with the first save point (the bench) has crazy flickering lights sources: the sky got some random darker garbage instead of bloom and the shimering bench gets randomly darker...

FlatOut, could you check this place too...?

EDIT:
Fog is also missing on the bridge at the same spot... (comparaison screenshot added)

[gregory]

@parotaku, check the CRC level, and be sure to use Nx upscaling.