[Solved][Dev] Question about GUI edit (Text descriptions for hacks)

[Ryudo]

Which one are you using though? There's several custom GSdx floating around after all.


I can always alter the description a bit more to be more generalized rather than focusing on one game if it truly works for other games. (GoW2 is one of the few games I didn't test it on.)

[K.F]

Idk what wiki pages are claiming that

Several:

http://wiki.pcsx2.net/index.php/Chaos_Legion
http://wiki.pcsx2.net/index.php/Yakuza
http://wiki.pcsx2.net/index.php/Yakuza_2
http://wiki.pcsx2.net/index.php/ICO
http://wiki.pcsx2.net/index.php/Devil_May_Cry

and many others.

but feel free to remove it. I clearly stated it was for ToA only.

Remove what? all these pages, or your change?

I'd understand one or two people could make this mistake, but all these people making the same mistake in different games is not likely.

Hack made for a game =/= Hack works only on that game.

[vsub]

It's old and from the buildbot
GSdx 20150529225653 (MSVC 18.00, SSE41) 0.1.16 [GSdx32-AVX2]
I don't update often

[ssakash]

It also helps ghosting Issues on DBZ:BT series ( It was either 2(or) 3, don't exactly remember it). Though I don't really think there is a need to alter the description for general games since the Patch was specifically aimed at a certain game.

Though, Extra Information will also be good.

[Ryudo]

I think everyone is making the mistake here thinking I'm changing the original Halfpixel offset hack description.

The patch modified Halfpixel offset hack, so it's not the same anymore.

This patch (the modified code) was aimed for one game only, and that's ToA. It modified coordinates of the HP hack that are SPECIFIC to ToA.

http://wiki.pcsx2.net/index.php/Devil_May_Cry
This wiki page only states an older GSdx, and the general halfpixel offset hack for example. So yes, the hack (THE NORMAL DEFAULT ONE), would work there. But not this modified code version.

Old:

Code:

ox2 *= rt->OffsetHack_modx;
oy2 *= rt->OffsetHack_mody;

New:

Code:

ox2 *= rtsize.x / 1024.0f * 1.8f;
oy2 *= rtsize.y / 816.2f * 1.8f;

The new code is aimed for ToA. It might work for other games, but I doubt it. You're welcome to try it though. http://forums.pcsx2.net/Thread-tota-s-gh...#pid444255 (Version of may 5th can be downloaded there. Still gotta update it with the latest GSdx)

[refraction]

So let me get this straight, you're modifying a useful on many games hack (and I know for a fact it is) so it only works with 1 game?

If that's the case, no, it's not going in.

[Ryudo]

I never wanted it to be officially added to pcsx2 o.o Where did you see me state that?

I merely wanted to update the description for people who downloaded the custom GSdx to find the correct hack easier.

People can choose to download it or not. I never said it was supported either by PCSX2.

Right now it's just a workaround for the ghosting issue in ToA.

[K.F]

So you are talking about your own version that is aimed at ToA?

Knock yourself out then

Edit: Ninjaed

Why won't you add it -properly- to the main branch if it actually works?

[Ryudo]

So you are talking about your own version that is aimed at ToA?

Knock yourself out then

Why won't you add it -properly- to the main branch if it actually works?

Yep pretty much.


The reason why I never added it to the main branch is that it creates a border of 1 pixel when you apply the hack on the left and top side. :/ I have yet to find a way to resolve that. It's due to the shifting of the 'ghosted' areas I'm guessing, so it might be impossible to remove it, but I'll see if I can get it working.


Eventually if this does get fully fixed, we can just add it as a separate gamefix or whatever. But for now it's just a temporary workaround, freely available for users to download. Of course if they get issues with PCSX2 they won't have support for it, because it's a custom build after all. But that's also why I made it VERY clear that it's only for Tales of the Abyss. I even named the plugin file for ToA only.

[refraction]

Why won't you add it -properly- to the main branch if it actually works?

I would if it was separate from the hack it modified.