Posts: 67
Threads: 3
Joined: Jan 2015
Reputation:
4
Location: Chicago
(12-26-2016, 01:48 AM)FlatOut Wrote: As soon as someone merges my PR it will work again. So, it should be fixed sometime between now and the end of 2018.
Awesome!
hahaha! I am willing to wait for it.... lol
Merry Christmas!
Windows 8.1 Pro 64-bit
Intel i7 4790k 4.00 Ghz
Gigabyte Geforce GTX 1080 8GB
16GB Ram
Direct X11
OpenGL version 4.6
Current resolution: 3840x2160
Posts: 20.369
Threads: 405
Joined: Aug 2005
Reputation:
555
Location: England
Wow, why are you being so paranoid about what I think about your PR? I don't know if it's tested and working properly, I didn't look, why is that such a big deal that you have to give up on everything? If I just assumed everything worked because of the person committing it, pcsx2 would be quite unstable right now
Posts: 21.718
Threads: 401
Joined: Sep 2013
Reputation:
476
Location: 私の夢の中
That makes little to no sense. ANYONE is capable of making errors, that's why we have PRs and review systems. I've only made a few PRs in my day here but two of them had errors (one serious enough to break the HW hacks box entirely) despite me checking and checking again. It's hard to proofread your own code for the same reason it's hard to proofread your own writing - you see what you expect, not what is there.
Gaming Rig: Intel i7 6700k @ 4.8Ghz | GTX 1070 TI | 32GB RAM | 960GB(480GB+480GB RAID0) SSD | 2x 1TB HDD