Posts: 1.362
Threads: 14
Joined: Feb 2009
Reputation:
36
I personally use 3x for my 1920x1200 res monitor. I have never used Custom resolution in all the time I have been messing around with the emulator all the way back to when I was using an AMD Athlon 64bit x2 3800+ with a Nvidia 7600gs GPU. So I am all for removing it competely to clean up the code and pave the way for future accuracy.
Posts: 12.837
Threads: 48
Joined: Oct 2013
Reputation:
252
If we could make an option for a screenshot res that would be fine. I'm not sure exactly how you would render the game at a specified res then go back to a multiple of native without causing issues.
Posts: 8.597
Threads: 105
Joined: May 2014
Reputation:
168
Location: 127.0.0.1
I intended to make tabs for the GSdx plugin settings to separate the options, maybe that way we wouldn't need to worry about space.
We're supposed to be working as a team, if we aren't helping and suggesting things to each other, we aren't working as a team.
- Refraction
Posts: 153
Threads: 1
Joined: Mar 2013
Reputation:
3
Location: Veldin
I'm actually totally cool with removing custom resolutions, except I use ridiculous resolutions when taking screenshots for articles (I think 10x is what my gpu handles), so I use it for that. I do agree with taking away true custom resolution though, since I'm not sure that can do much without breaking games and technology is just going to improve, so using fractions of IR is going to be useless soon enough.
Posts: 3.377
Threads: 57
Joined: Feb 2013
Reputation:
57
Don't forget 1.5x, 1.75x, etc. I don't agree on the removal. It's just an option. If it causes issues, you can always not use it. You can add a tooltip explaining that this option may cause issues if you concern that the users may not understand. Also, I don't think the space in the UI is an issue. Currently the "Custom" option is in the drop-down list and the custom resolution boxes take up only one line of space.
Regarding the code, could you please show it to me? I'll make suggestions on how to improve it or if it needs improvements when I have time.
Posts: 8.597
Threads: 105
Joined: May 2014
Reputation:
168
Location: 127.0.0.1
@xemnas99
The problem is that some games like Baldurs gate take the x and y values of the custom res when native resolution is enabled , which eventually was fixed by ref by adding conditional checks to make sure that the x&y values are applied only when native resolution is disabled. This is just one of the issues, there are lot of other stuffs where the custom res is bothering in the codebase.
We're supposed to be working as a team, if we aren't helping and suggesting things to each other, we aren't working as a team.
- Refraction
Posts: 6.069
Threads: 68
Joined: May 2010
Reputation:
167
Location: Grenoble, France