GSdx

[ssakash]

@Gregory

I have made the round offset hack checkbox in the following format,
0 // Inactive - null checkbox
1 // active for flat sprites - ticked checkbox
2 // active for all sprites - square checkbox

Is this okay ? can I send the PR ?

[Blyss Sarania]

That's so backwards, as I said in the PM.

I know a way you could reverse it with if statements but there has got to be a better way.

[ssakash]

Yeah, I also thought of doing some If statements but, that would be a waste of lines and efficiency.

[tsunami2311]

shouldnt it be check for all and box for flat, like the other hacks that use similar options?

[ssakash]

no, only wild arms offset and sprite hack use that format.

[karasuhebi]

I have to disagree with you ssakash. Usually the gray option is the 'half-way' option and the check is the '100% full on' option. For example, look at GSdx's Texture Filtering. The default (gray) only filters 3D textures, while the check filters all of them. I've always looked at the grayed box as the in-between option that sits in the middle of off and on.

[tsunami2311]

no, only wild arms offset and sprite hack use that format.

pretty sure Texture filtering is

check= 3d/2d
box = 3d only

[ssakash]

yeah, I also thought of doing the same way for round offset hack but, as blyss said there has to be some other way to change the variables to match the certain check box format rather than using conditional statements, I'm trying to figure out the another way for the method.

pretty sure Texture filtering is

check= 3d/2d
box = 3d only

oops, sorry. I thought you were talking about the the functions on HW hacks.

[Blyss Sarania]

Yeah it definitely needs reversed but doing it with if statements would be too messy. Maybe ask on the IRC?

[ssakash]

could you provide a link to the IRC ?