..:: PCSX2 Forums ::..

Full Version: GSdx
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563
(01-04-2015, 06:44 PM)rama Wrote: [ -> ]Yea, that does help. Thanks Smile
So this looks like a hack to me. If anyone understands what it does, please explain.
We do have a hacks section in GSdx so if it's any useful (not breaking too much, etc), then
we can add it there.

Why do you think it's a hack?

According to the source code, it checks the value of FBP (Frame.Block()). If anybody knows what FBP is, please explain.

If FBP doesn't equal zero, the default behavior (DrawPrims()) is executed. If anybody knows what DrawPrims() does, please explain.

Else, it seems that it stretches the texture (StretchRect()) by 1024 x 256.

If we know what the following are/do, we'll understand this:
- FBP
- DrawPrims function
- StretchRect function
- rt->m_texture and tex->m_texture
Hello, I made the patch originally,

From what I remember when making this,

DrawPrims() loads appropriate shaders and makes the D3D Draw calls onto the rendertarget (with a given texture and primitives buffer).
StretchRect() is just a native D3D function to resize and copy a texture.

rt is the rendertarget and tex is a working copy of the rendertarget from previous calls (in this case).

FBP I dont understand so well, but if you look at other game-specific hacks in GSdx, it is often used to target a specific render point.


With enthusia (probably all games), most of the Draw calls are made on a strange sized rendertarget before finally being resized to fit the window.

Now as to what is cause the vertical lines in DrawPrims(), this may not be true, but I believe it is a float to integer conversion error (eg; 126.5 converts to 126 instead of 127 somewhere) when the shader is resizing final rendertarget result to the correct size. The other possibility is a floating-point precision error. (due to the scale values being so small)

I avoided this by using StretchRect to stretch/resize the working copy to the rendertarget, in replacement of the shader doing the stretching.

1024/256 multiplied by the rt scale value seems to replicate what the shader was suppose to resize it to.


Basically the shader stretching function has a bug, not sure which shader or why.. but it seems to be the last draw call before the rendertarget is Present()'d to the backbuffer.



Also a quick tip, I used NVIDIA PerfHUD to track down the exact point the black lines were introduced. It allows you to view the rendertarget after each draw call.


Hope this clears things up and looking forward to seeing an official patch!
Thank you for the explanation. Rep+1.
@racer_s
did you use NVIDIA PerfHUD to clarify that the last draw call before the render target is Present()'d to the backbuffer.
(12-28-2014, 04:56 PM)hellbringer616 Wrote: [ -> ]tried it with Soul Calibur 3, All it does it crash.
Shame too, was hoping to play this game with real scaling.

It make pcsx2 crash for me too. Any fix found? My setup is i7 2760qm and gtx 560m. Tested on builds from early Dec and early Jan

Nice work on the fix/hack btw. If you like racing games maybe you can look at R Racing Evolution, it doesn't even render the cars lol
Iirc this patch only works for avx instruction set.
Both my 3570k and my 6800k have AVX, I am actually using the precompiled AVX plug-in from the latest GIT for Soul Calibur 3. Works great. So at least for me, that isn't the issue.
It should work with PCSX2 1.2.1.
Though, He mentioned it was for 1.0.0
He said that it worked with the latest 1.2 release. I think he meant the stable release.
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563