..:: PCSX2 Forums ::..

Full Version: GSdx
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563
(03-26-2015, 03:27 AM)Blyss Sarania Wrote: [ -> ]I gotta say, Asmodean's FXAA is so amazing. It is quite literally the only shader based AA I've ever seen that isn't a bloody mess. It has practically no blur and actually anti aliases reasonably well. It's got nothing on MSAA, but for games that can't use that, it's amazing.

I told him the same thing his FXAA blow nvidia implementation away. I kind wish i should set nvidia's FXAA up like his so i could use in swtor and not deal with horrid bluring nvidia's has
Yeah I was wondering myself if it could be implemented in PC games.
He uses very little sub-pixel AA in his implantation for the standard setup, that's why it AA's pretty well. (I believe the default is 0.25 out of 1.00) You could do 0.00 for straight up only edge detection, but I have a hard time noticing the difference as it is.

You could mimic the result with PC games by using SMAA and turning off anything related to sub-pixel aliasing. FXAA is pretty dodgy, or at least, in my experience.
(03-26-2015, 02:24 PM)Bigbenn01 Wrote: [ -> ]FXAA is pretty dodgy, or at least, in my experience.

Exactly, which is why I've been so impressed with Asmodean's.

Here is a comparison. In Persona 3, it doesn't AA the environment that well, but it does well on the characters. These are giant PNG for maximum quality(4x+FXAA):

Off:
[Image: off.png]

On:
[Image: 1.png]

Look around Mitsuru's hair and skirt, and the tables for examples where it does quite well. Unfortunately, it does miss e.g. the light fixtures, but I'll accept that as a trade off for no blur.
(03-26-2015, 09:00 PM)Blyss Sarania Wrote: [ -> ]Exactly, which is why I've been so impressed with Asmodean's.

By dodgy I think he meant it has worse coverage. FXAA was designed to be almost as cheap as possible to run, and as a result doesn't handle long edges as well as smaa and cmaa.

So if you configure smaa in a similar way you'll still end up with higher quality.
Ahh, I see.

I've always preferred SMAA to FXAA but still hate them both(except for Asmodean's). SMAA does a better job, is less blurry, but is quite smeary.
Ok boy, I have a hack that improves black line issue in various game (ace combat / mana khemia video / colin 3)

The patch will give you a very small distortion of sprite rendering boundary. It could be less uglier than black line.

Add this option into your GSdx.ini file
Quote:UserHacks_align_sprite_X = 1

Please find the patch below (or in attachment)
Code:
diff --git a/plugins/GSdx/GSRendererHW.cpp b/plugins/GSdx/GSRendererHW.cpp
index fc4e5ef..5cb6971 100644
--- a/plugins/GSdx/GSRendererHW.cpp
+++ b/plugins/GSdx/GSRendererHW.cpp
@@ -32,6 +32,8 @@ GSRendererHW::GSRendererHW(GSTextureCache* tc)
{
        m_upscale_multiplier = theApp.GetConfig("upscale_multiplier", 1);
        m_userhacks_skipdraw = !!theApp.GetConfig("UserHacks", 0) ? theApp.GetConfig("UserHacks_SkipDraw", 0) : 0;
+       // Hack to avoid various black vertical line issue
+       m_userhacks_align_sprite_X = !!theApp.GetConfig("UserHacks_align_sprite_X", 0);

        if(!m_nativeres)
        {
@@ -295,6 +297,22 @@ void GSRendererHW::Draw()
        context->FRAME.FBMSK = fm;
        context->ZBUF.ZMSK = zm != 0;

+       // Hack to avoid black line in various games (ace combat/mana khemia/colin 3).
+       if (m_userhacks_align_sprite_X) {
+               if (m_vt.m_primclass == GS_SPRITE_CLASS) {
+                       size_t count = m_vertex.next;
+                       GSVertex* v = &m_vertex.buff[0];
+                       for(size_t i = 0; i < count; i += 2) {
+                               int x  = v[i+1].XYZ.X;
+                               int ox = context->XYOFFSET.OFX;
+                               // Transform i.d into i.9375 (int12:4 format). It avoid wrong vertical line
+                               // generated by upscaling.
+                               v[i+1].XYZ.X = ((x-ox) | 0xF) + ox;
+                       }
+               }
+       }
+
+
        //

        DrawPrims(rt->m_texture, ds->m_texture, tex);
diff --git a/plugins/GSdx/GSRendererHW.h b/plugins/GSdx/GSRendererHW.h
index 405257a..19b87f6 100644
--- a/plugins/GSdx/GSRendererHW.h
+++ b/plugins/GSdx/GSRendererHW.h
@@ -35,6 +35,8 @@ private:
        bool m_reset;
        int m_upscale_multiplier;
        int m_userhacks_skipdraw;
+
+       bool m_userhacks_align_sprite_X;
        
        #pragma region hacks
I wonder if this works with Ar tonelico, where the face sprites are messed up with any kind of upscaling? I'll have to try once I get Visual Studio reinstalled.
Upscaling generates a lots of accuracy issue (so far, input texture too small / input primitive too small / wrong window offset). My hack increases the size of the sprite without increase the mapped texture size. Texture will be a little stretched. I'm afraid it will be horrible for small spirit.

Anyway, if you can generate me a gs dump of Ar tonelico, I will give it a look.
I have compiled SSE2 and SSE4 versions of this hack. The results in ace combat 5 are definitively worth the tiny imperfections.

Gs dump is here
And please, be aware you'll have to use m_userhacks_RemoveHoleBetweenSprite=1 instead of the option Gregory previously mentioned
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563